I have found that the .com.apple.TimeMachine.quota.plist file is a much more reliable way to set a TM quota.
Sorry. Quite overloaded with work on SCALE right now. First place to check is to verify that parameter is being set in smb.conf. If it's set there, ping me again and I'll take a look at vfs_fruit to make sure something hasn't changed there.
root@freenas[~]# testparm -s
[...]
[Backup]
ea support = No
guest ok = Yes
mangled names = no
path = /mnt/hdd/share/timemachine
read only = No
vfs objects = catia fruit streams_xattr noacl aio_fbsd
fruit:time machine max size = 1024G
fruit:locking = none
fruit:time machine = yes
fruit:resource = stream
fruit:metadata = stream
fruit:encoding = native
nfs4:chown = true
[...]
static uint64_t fruit_disk_free(vfs_handle_struct *handle,
const struct smb_filename *smb_fname,
uint64_t *_bsize,
uint64_t *_dfree,
uint64_t *_dsize)
{
struct fruit_config_data *config = NULL;
struct fruit_disk_free_state state = {0};
struct smb_Dir *dir_hnd = NULL;
const char *dname = NULL;
char *talloced = NULL;
long offset = 0;
uint64_t dfree;
uint64_t dsize;
bool ok;
SMB_VFS_HANDLE_GET_DATA(handle, config,
struct fruit_config_data,
return UINT64_MAX);
if (!config->time_machine ||
config->time_machine_max_size == 0)
{
return SMB_VFS_NEXT_DISK_FREE(handle,
smb_fname,
_bsize,
_dfree,
_dsize);
}
dir_hnd = OpenDir(talloc_tos(), handle->conn, smb_fname, NULL, 0);
if (dir_hnd == NULL) {
return UINT64_MAX;
}
while ((dname = ReadDirName(dir_hnd, &offset, NULL, &talloced))
!= NULL)
{
ok = fruit_tmsize_do_dirent(handle, &state, dname);
if (!ok) {
TALLOC_FREE(talloced);
TALLOC_FREE(dir_hnd);
return UINT64_MAX;
}
TALLOC_FREE(talloced);
}
TALLOC_FREE(dir_hnd);
dsize = config->time_machine_max_size / 512;
dfree = dsize - (state.total_size / 512);
if (dfree > dsize) {
dfree = 0;
}
*_bsize = 512;
*_dsize = dsize;
*_dfree = dfree;
return dfree / 2;
}
static bool fruit_tmsize_do_dirent(vfs_handle_struct *handle,
struct fruit_disk_free_state *state,
const char *name)
{
bool ok;
char *p = NULL;
size_t sparsebundle_strlen = strlen("sparsebundle");
size_t bandsize = 0;
size_t nbands;
off_t tm_size;
p = strstr(name, "sparsebundle");
if (p == NULL) {
return true;
}
if (p[sparsebundle_strlen] != '\0') {
return true;
}
DBG_DEBUG("Processing sparsebundle [%s]\n", name);
ok = fruit_get_bandsize(handle, name, &bandsize);
if (!ok) {
/*
* Beware of race conditions: this may be an uninitialized
* Info.plist that a client is just creating. We don't want let
* this to trigger complete failure.
*/
DBG_ERR("Processing sparsebundle [%s] failed\n", name);
return true;
}
ok = fruit_get_num_bands(handle, name, &nbands);
if (!ok) {
/*
* Beware of race conditions: this may be a backup sparsebundle
* in an early stage lacking a bands subdirectory. We don't want
* let this to trigger complete failure.
*/
DBG_ERR("Processing sparsebundle [%s] failed\n", name);
return true;
}
/*
* Arithmetic on 32-bit systems may cause overflow, depending on
* size_t precision. First we check its unlikely, then we
* force the precision into target off_t, then we check that
* the total did not overflow either.
*/
if (bandsize > SIZE_MAX/nbands) {
DBG_ERR("tmsize potential overflow: bandsize [%zu] nbands [%zu]\n",
bandsize, nbands);
return false;
}
tm_size = (off_t)bandsize * (off_t)nbands;
if (state->total_size + tm_size < state->total_size) {
DBG_ERR("tm total size overflow: bandsize [%zu] nbands [%zu]\n",
bandsize, nbands);
return false;
}
state->total_size += tm_size;
DBG_DEBUG("[%s] tm_size [%jd] total_size [%jd]\n",
name, (intmax_t)tm_size, (intmax_t)state->total_size);
return true;
}
log level = 1 fruit:10@/var/log/samba4/log.smbd.fruit. This will increase logging verbosity for VFS module and write it to a separate file. See if you have any errors being reported by the module (specifically from the above function).
fruit:time machine max size parameter is working for me again with 12.0-U7. Let's hope that stays with U8.[TimeMachine]
comment = Time Machine Backups
ea support = No
kernel share modes = No
path = /mnt/XX/TimeMachine/%U
posix locking = No
read only = No
smbd max xattr size = 2097152
vfs objects = tmprotect fruit streams_xattr shadow_copy_zfs nfs4acl_xattr zfs_core io_uring
zfs_core:base_user_quota = 5T
zfs_core:zfs_auto_create = true
tn:vuid = XX
fruit:time machine max size = 0
fruit:time machine = True
fruit:resource = stream
fruit:metadata = stream
nfs4:chown = True
nfs4acl_xattr:encoding = xdr
nfs4acl_xattr:xattr_name = system.nfs4_acl_xdr
nfs4acl_xattr:validate_mode = False
nfs4acl_xattr:nfs4_id_numeric = True
tn:home = False
tn:path_suffix = %U
tn:purpose = ENHANCED_TIMEMACHINE
If a quota has already been written, you can edit the user quota through the webui for the ZFS dataset in question.
