Bug Report: #4098 biting again

[forbiddenera]

Hey,

Sorry - I don't really have time to sign up for the bug tracker but wanted to report this.

In #4098 it was discovered that SMB doesn't like passwords containing a '?' character.

William Gzybowski added validation to reject passwords with a '?' because of this.

Personally, I think enforcing this on any password that isn't also specifically used for SMB is a bit insecure however that's not really the issue at hand.

When you first install TrueNAS and choose a root password during installation/initial, this check is not enforced; however when changing the root password with netcli, after a full configration reset (triggered through netcli) or within the browser, this check is enforced.

This resulted in me being able to use my desired password initially during install, but after a reset due to network issues - I was unable to use the same password.

My suggestion for a fix would be to only perform this additional verification steps either only on SMB accounts or at least avoid the check on the root account - I don't think any of us are (or should) be using the root account for SMB anyway.

 

[jgreco]

It is no longer possible to use the root account for SMB, due to changes upstream. Just informationally.

 

[anodos]

Original problem was actually misdiagnosed. I removed this validation from master, but didn't backport into the 12-stable branch.

 

[forbiddenera]

Original problem was actually misdiagnosed. I removed this validation from master, but didn't backport into the 12-stable branch.

I was wondering about that because it did seem a little odd. But if there was something that was going to be odd like that, SMB would be it, heh.

Was a bit frustrating because I didn't want to do a whole reinstall and changing the password to something else kinda annoying. I just changed the file temporarily.

Just thought I'd make it known :)