Min protocol not allowed in SMB share options

[gamebrigada]

Hey guys,

In TrueNAS 12.0-U5.1, when I try to add min protocol to Auxiliary Parameters to a share, I get this error. Current version of Samba still seems to support it. I need to set min protocol to NT1 and definitely don't want to do that system wide. This worked fine in all versions of FreeNAS 11.

Error: Traceback (most recent call last):​

File "/usr/local/lib/python3.9/site-packages/middlewared/main.py", line 138, in call_method​

result = await self.middleware._call(message['method'], serviceobj, methodobj, params, app=self,​

File "/usr/local/lib/python3.9/site-packages/middlewared/main.py", line 1205, in _call​

return await methodobj(*prepared_call.args)​

File "/usr/local/lib/python3.9/site-packages/middlewared/service.py", line 673, in update​

rv = await super().update(app, id, data)​

File "/usr/local/lib/python3.9/site-packages/middlewared/service.py", line 495, in update​

rv = await self.middleware._call(​

File "/usr/local/lib/python3.9/site-packages/middlewared/main.py", line 1205, in _call​

return await methodobj(*prepared_call.args)​

File "/usr/local/lib/python3.9/site-packages/middlewared/schema.py", line 973, in nf​

return await f(*args, **kwargs)​

File "/usr/local/lib/python3.9/site-packages/middlewared/plugins/smb.py", line 960, in do_update​

await self.middleware.call('sharing.smb.apply_conf_diff',​

File "/usr/local/lib/python3.9/site-packages/middlewared/main.py", line 1248, in call​

return await self._call(​

File "/usr/local/lib/python3.9/site-packages/middlewared/main.py", line 1205, in _call​

return await methodobj(*prepared_call.args)​

File "/usr/local/lib/python3.9/site-packages/middlewared/plugins/smb_/registry.py", line 227, in apply_conf_diff​

return await self.apply_conf_registry(share, confdiff)​

File "/usr/local/lib/python3.9/site-packages/middlewared/plugins/smb_/registry.py", line 208, in apply_conf_registry​

await self.reg_setparm(share, k, v)​

File "/usr/local/lib/python3.9/site-packages/middlewared/plugins/smb_/registry.py", line 106, in reg_setparm​

return await self.netconf(action='setparm', share=share, args=[parm, value])​

File "/usr/local/lib/python3.9/site-packages/middlewared/plugins/smb_/registry.py", line 61, in netconf​

raise CallError(​

middlewared.service_exception.CallError: [EFAULT] net conf setparm [scan] failed with error: Global parameter 'server min protocol' not allowed in service definition ('test').​

 

[anodos]

This is actually an error being passed up from libsmbconf (from Samba). `server min protocol` is a global parameter and may not be set in a share.

 

[gamebrigada]

Hmm, that's odd that it worked fine in previous versions and the current version man page leads me to believe it should still work. We did use "min protocol", the specific error used "server min protocol" which should be equivalent.

 

[anodos]

Code:

<samba:parameter name="server max protocol"
                 context="G"
                 type="enum"
                 enumlist="enum_protocol"
                 xmlns:samba="http://www.samba.org/samba/DTD/samba-doc">

context="G" means that it's global-only.