I'm a home user, and I used Freenas for many years, then switched to Truenas Core, then last year switched to Truenas Scale.
I can say categorically that I made the right decision to switch to Scale. Core is fine, but my guess is that it won't be maintained over the long run because it's not useful to the enterprise and to iXsystems' business model.
Also, Linux Debian, the base of Scale, is compatible with a far greater selection of hardware than FreeBSD, the base of Core. This is not just theoretical. At one point, I was using a 2.5GBPS network card that was recognized by Scale but not Core.
Moreover, most of the problems mentioned in this thread have to do with apps and VMs. I use a NAS for data storage, and I would not want to complicate it by adding apps or VMs. That's not the core mission of a NAS. I don't need a "jack of all trades" box. It seems safer to keep a NAS for NAS purposes and a separate box for other stuff, although admittedly that does boost the energy cost and carbon footprint a bit. In any event, Core has never been particularly good for running apps (containers) or VMs, so whatever problems Scale has with this are likely no better in Core.
Finally, I agree that it's inconvenient that rsync modules are being phased out. The claim that they're insecure is dubious given that they're no more insecure than NFS, which I suspect is the central use of most Scale installations.
That being said, switching rsync tasks to SSH is not difficult. See a separate post I made about this for steps to do it, based on my own experience. Moreover, I've found that there are some slight advantages with SSH compared to modules, having nothing to do with security. Namely, the file paths are stored on the Scale server rather than the remote host with SSH, which is better in my opinion because they're easy to back up through a configuration backup, whereas with modules, if the remote host system drive becomes unreadable, then the paths are lost unless one has a Clonezilla or other backup.