Invalid Choice (ON)

[Trevor68]

If you try to edit a ZVol then you get a message saying ON is an invalid choice for compression, even though that is what is currently set.

 

[ABain]

Do you happen to know which version of TrueNAS the ZVol was created on? My guess is this is a migration issue and I want to reproduce, I checked on 22.12.4 and the options are consistent with Cobia, so I suspect these were created on an earlier release?

 

[Trevor68]

Actually no, these are two brand new zvols as I try to recreate my VM's onto UEFI BIOS settings. So they were created on Cobia. I had got them both up and running, but then decided to make them larger so struck this when I went to edit them.
In the list of options LZ4 was Recommended so I manually changed them both to LZ4. otherwise I would not have been allowed to edit .

 

[HoneyBadger]

@Trevor68 did you initially create this pool on an older FreeNAS version? zpool history output will indicate the "born on" date of your pool, but I suspect it's from an older version as compression=on is a legacy ZFS behavior.

If this is the case, then you're running lzjb compression and I'd consider switching your entire pool to LZ4 - while the existing data won't benefit (unless you re-wrote it all) the new data will at least be able to benefit from significantly better performance overall.

Some very generalized performance numbers below:

Code:

Compressor name         Compress. Decompress. Compr. size  Ratio
lz4 1.9.2                 235 MB/s  1446 MB/s    26435667  51.61
zstd_fast 1.4.5 --1       153 MB/s   558 MB/s    22027595  43.01
lzjb 2010                 151 MB/s   186 MB/s    28867642  56.36
zstd 1.4.5 -3              72 MB/s   380 MB/s    18507463  36.13

 

[Trevor68]

oh you mean the pool the zvols are stored on, yes that pool is original to Scale I think it was the Angelfish RC when I fired up this lab.

 

[Trevor68]

Interesting, I have 3 pools, all created at the same time, and I thought all identical, but nope. The other 2 pools have compression level lz4, the pool with the VM's just says ON for the compression level.

 

[HoneyBadger]

Interesting, I have 3 pools, all created at the same time, and I thought all identical, but nope. The other 2 pools have compression level lz4, the pool with the VM's just says ON for the compression level.

How unusual. I wouldn't expect anything on OpenZFS (as opposed to the legacy ZFS module) to use that setting.

Can you grab a debug file (System -> Advanced -> Save Debug) before correcting this and include this with a bug report? Even though the "on" setting is no longer valid we'll want to include something in the UI to handle legacy pools that have managed to upgrade all this way.

 

[Trevor68]

Sorry I changed them to LZ4 without a debug. I do have 2 old tickets with debugs attached though if that helps.

 

[HoneyBadger]

As long as they're fairly recent it should have value, and zpool history goes back to pool creation so even one collected now should help.

Just so I don't duplicate the bug tracker - did you file one for this issue (can't edit the zvol settings as "on" was an invalid value?)

 

[Trevor68]

No as I wasn't sure what was happening, in at work now, but can attach history and an old debug here in a few hours

 

[Trevor68]

here you go

 

[HoneyBadger]

@Trevor68 I removed the debug attachment; we generally try to keep those as private uploads for bug reports.

Checked on it myself - it appears that the nvme-storage pool was created manually?

Code:

zpool create -f nvme-storage /dev/nvme0n1p5

 

[Trevor68]

It may well have been, which would explain why it is different, I have a terrible memory! I think I may have done that because it uses a partition of my nvme drive and a ssd as the mirror. Originally I did not want to waste the entire nvme drive so I partitioned off 32gig for my boot drive.

This would make me very much an edge case so sorry for wasting your time!

 

[HoneyBadger]

It does make it an edge case, but not a waste of time. If someone's been running a ZFS pool on FreeNAS since version 8, we want to make sure they aren't left out of all the fun either. :)