it works great with truenas scale - just be aware, that you should expect grinch comments. regarding external connections: eveything expect SAS is "bad" for some people.
That is not quite accurate. M.2 PCIe NVMe, built in SATA, and some ASMedia SATA chips work well. And have been pointed out by the Grinch.
The big thing with many external desktop USB or Thunderbolt enclosures, is that they are not designed to run 24x7x365. Now you might say some ARE designed for 24x7x365. That may be true for other OSes and file systems.
ZFS on the other hand does things differently. Their are 2 differences. ZFS will bundle writes into transaction groups, then burst write the data. Slower interfaces, or more likely corner case bugs in firmware or logic can de-rail those writes. Rare, but it happens. And it might not happen for months or years. Though when it happens, could be data loss.
The more common problem would be twice a month ZFS scrubs which can hit the drives with continuous reads. Not just for hours, but could be all day. Or even multiple days. These USB external enclosures may not be able to handle the heat and get rid of it fast enough to prevent drive damage. Now will such an USB external enclosure fail on the first ZFS pool scrub? Of course not. But, over time, drive damage it is more likely than proper enclosures.
Your mileage may vary...