"Stale file handle" when list snapshots (.zfs)

[grahamperrin]

Is there any update?

There's recent discussion in Bugzilla for FreeBSD.

266236 – ZFS NFS : .zfs/snapshot : Stale file handle

bugs.freebsd.org

 

[anodos]

https://github.com/truenas/zfs/pull/98 that PR contains fix for zfs snapdir.

 

[grahamperrin]

FreeBSD: Fix a pair of bugs in zfs_fhtovp() · openzfs/zfs@ed566bf

- Add a zfs_exit() call in an error path, otherwise a lock is leaked. - Remove the fid_gen > 1 check. That appears to be Linux-specific: zfsctl_snapdir_fid() sets fid_gen to 0 or 1 dependin...

github.com

 

[mpfusion]

Since #117270 is still private I can't find out if TrueNAS 13.0-U3 fixes that particular bug. Does anyone know if the fix is included in U3?

 

[Volts]

I don't think it's in 13.0-U3.

It's not listed in the release notes.

But also, the 13.0-U3 ISO is dated 2022-10-31.

https://download.freenas.org/13.0/STABLE/U3/x64/

And the fix appears in truenas/os on 2022-11-01.

zfs: Fix a pair of bugs in zfs_fhtovp() · truenas/os@7ab877c

This cherry-picks upstream ed566bf1cd0bdbf85e8c63c1c119e3d2ef5db1f6 - Add a zfs_exit() call in an error path, otherwise a lock is leaked. - Remove the fid_gen > 1 check. That app...

github.com

It does appear to be in the latest TrueNAS-13.1-Nightlies nightlies.

 

[mpfusion]

Bummer. Thanks for the info. Waiting for 13.0-U4 then.

 

[grahamperrin]

<https://github.com/openzfs/zfs/commit/ed566bf1cd0bdbf85e8c63c1c119e3d2ef5db1f6>

Errata notice:

FreeBSD-EN-22:24.zfs

ZFS snapshot directories not accessible over NFS

• there's a .patch file.

 

[blanchet]

The issue is fixed in TrueNAS-13.0u4.