"Everyone" given special permissions in CIFS share

[Nick2253]

When I create a new CIFS share, the "Everyone" account is given special permissions to "Delete subfolders and files". This means that, if you create a share, and you allow guest access, then anyone can delete all of your things. Even if you don't allow guest access, the permissions are still set that same way.

It's easy enough to fix this, but it's kind of a pain when you've got a handful of shares, and all your data gets deleted.

I'm assuming this is just an oversight, but if it's not, could someone please explain to me why this behavior would be desirable? It seems highly undesirable to me.

 

[dlavigne]

And what is the fix? Is the fix something that should be created as a feature request at bugs.freenas.org?

 

[Nick2253]

I meant that it's easy enough to fix it after-the-fact by simply changing the permissions on the share. I have no idea how to fix it in the code.

And I wouldn't exactly call this a feature. In my mind, this is clearly a bug.

 

[Nick2253]

Bug report added:

https://bugs.freenas.org/issues/4910